modules/saml: proper error message in SAML1.1/2.0 ACS when auth source ID is missing.

modules/saml/www/sp/saml1-acs.php

@@ -8,6 +8,10 @@ if (!array_key_exists('TARGET', $_REQUEST)) {
 	throw new SimpleSAML_Error_BadRequest('Missing TARGET parameter.');
 }
 
+if (!array_key_exists('PATH_INFO', $_SERVER)) {
+    throw new SimpleSAML_Error_BadRequest('Missing authentication source ID in assertion consumer service URL');
+}
+
 $sourceId = $_SERVER['PATH_INFO'];
 $end = strpos($sourceId, '/', 1);
 if ($end === FALSE) {

modules/saml/www/sp/saml2-acs.php

@@ -4,6 +4,10 @@
  * Assertion consumer service handler for SAML 2.0 SP authentication client.
  */
 
+if (!array_key_exists('PATH_INFO', $_SERVER)) {
+    throw new SimpleSAML_Error_BadRequest('Missing authentication source ID in assertion consumer service URL');
+}
+
 $sourceId = substr($_SERVER['PATH_INFO'], 1);
 $source = SimpleSAML_Auth_Source::getById($sourceId, 'sspmod_saml_Auth_Source_SP');
 $spMetadata = $source->getMetadata();

modules/saml/www/sp/saml2-logout.php

@@ -7,7 +7,7 @@
  */
 
 if (!array_key_exists('PATH_INFO', $_SERVER)) {
-	throw new SimpleSAML_Error_BadRequest('Missing authentication source id in logout URL');
+	throw new SimpleSAML_Error_BadRequest('Missing authentication source ID in logout URL');
 }
 
 $sourceId = substr($_SERVER['PATH_INFO'], 1);