Skip to content
Snippets Groups Projects
Commit 542751a0 authored by Tim van Dijen's avatar Tim van Dijen Committed by Tim van Dijen
Browse files

Fix ArtifactResolution #1343 (#1344)

Fix ArtifactResolution due to misuse of Issuer
parent dceefef0
No related branches found
No related tags found
No related merge requests found
...@@ -15,6 +15,7 @@ use SAML2\ArtifactResolve; ...@@ -15,6 +15,7 @@ use SAML2\ArtifactResolve;
use SAML2\ArtifactResponse; use SAML2\ArtifactResponse;
use SAML2\DOMDocumentFactory; use SAML2\DOMDocumentFactory;
use SAML2\SOAP; use SAML2\SOAP;
use SAML2\XML\saml\Issuer;
use SimpleSAML\Configuration; use SimpleSAML\Configuration;
use SimpleSAML\Error; use SimpleSAML\Error;
use SimpleSAML\Module; use SimpleSAML\Module;
...@@ -58,6 +59,10 @@ if (!($request instanceof ArtifactResolve)) { ...@@ -58,6 +59,10 @@ if (!($request instanceof ArtifactResolve)) {
} }
$issuer = $request->getIssuer(); $issuer = $request->getIssuer();
if (!is_string($issuer)) {
$issuer = $issuer->getValue();
}
$spMetadata = $metadata->getMetaDataConfig($issuer, 'saml20-sp-remote'); $spMetadata = $metadata->getMetaDataConfig($issuer, 'saml20-sp-remote');
$artifact = $request->getArtifact(); $artifact = $request->getArtifact();
...@@ -73,7 +78,10 @@ if ($responseData !== null) { ...@@ -73,7 +78,10 @@ if ($responseData !== null) {
} }
$artifactResponse = new ArtifactResponse(); $artifactResponse = new ArtifactResponse();
$artifactResponse->setIssuer($idpEntityId); $issuer = new Issuer();
$issuer->setValue($idpEntityId);
$artifactResponse->setIssuer($issuer);
$artifactResponse->setInResponseTo($request->getId()); $artifactResponse->setInResponseTo($request->getId());
$artifactResponse->setAny($responseXML); $artifactResponse->setAny($responseXML);
Module\saml\Message::addSign($idpMetadata, $spMetadata, $artifactResponse); Module\saml\Message::addSign($idpMetadata, $spMetadata, $artifactResponse);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment