Deprecate SimpleSAML_Utilities::disanleXMLEntityLoader(). Since we are...

Deprecate SimpleSAML_Utilities::disanleXMLEntityLoader(). Since we are requiring PHP 5.3, we can call libxml_disable_entity_loader() directly.

lib/SimpleSAML/Utilities.php

@@ -1624,6 +1624,7 @@ class SimpleSAML_Utilities {
 	 * Disable the loading of external entities in XML documents to prevent local and
 	 * remote file inclusion attacks. This is in most cases already disabled by default
 	 * in system libraries, but to be safe we explicitly disable it also.
+	 * @deprecated This function will be removed in SSP 2.0. Please use libxml_disable_entity_loader() instead.
 	 */
 	public static function disableXMLEntityLoader() {
 		/* Function only present in PHP >= 5.2.11 while we support 5.2+ */

www/_include.php

@@ -108,4 +108,4 @@ if (!file_exists($configdir . '/config.php')) {
 /* Set the timezone. */
 SimpleSAML_Utilities::initTimezone();
 /* Disable XML external entity loading explicitly. */
-SimpleSAML_Utilities::disableXMLEntityLoader();
+libxml_disable_entity_loader();