Ignore invalid hook names

Sometimes we patch or edit a hook to meet our specific needs.
Somtimes this leaves behind a file like FILENAME.orig. The hook
detection login still runs these other files, making for confusing
debugging issues. Use a stricter match on what makes a valid hook name
to avoid these issues.

lib/SimpleSAML/Module.php

@@ -496,7 +496,7 @@ class Module
                 continue;
             }
 
-            if (!preg_match('/hook_(\w+)\.php/', $file, $matches)) {
+            if (!preg_match('/^hook_(\w+)\.php$/', $file, $matches)) {
                 continue;
             }
             $hook_name = $matches[1];

tests/lib/SimpleSAML/ModuleTest.php

@@ -112,4 +112,26 @@ class ModuleTest extends TestCase
             '\SimpleSAML\Auth\ProcessingFilter'
         ));
     }
+
+    /**
+     * Test for SimpleSAML\Module::getModuleHooks(). It covers happy path.
+     */
+    public function testGetModuleHooks(): void
+    {
+        $hooks = Module::getModuleHooks('saml');
+        $this->assertArrayHasKey('metadata_hosted', $hooks);
+        $this->assertEquals('saml_hook_metadata_hosted', $hooks['metadata_hosted']['func']);
+        $expectedFile = dirname(__DIR__, 3) . '/modules/saml/hooks/hook_metadata_hosted.php';
+        $this->assertEquals($expectedFile, $hooks['metadata_hosted']['file']);
+    }
+
+    /**
+     * Test for SimpleSAML\Module::getModuleHooks(). It covers invalid hook names
+     */
+    public function testGetModuleHooksIgnoresInvalidHooks(): void
+    {
+        $hooks = Module::getModuleHooks('../tests/modules/unittest');
+        $this->assertArrayHasKey('valid', $hooks, 'hooks=' . var_export($hooks, true));
+        $this->assertCount(1, $hooks, "Invalid hooks should be ignored");
+    }
 }

tests/modules/unittest/README.md

+For some unit tests we need a module that has a specific setup or issues.

tests/modules/unittest/hooks/hook_invalid.php.orig

+<?php
+
+// Hook detection should not load this file since it does not conform to the hook naming scheme

tests/modules/unittest/hooks/hook_valid.php

+<?php
+
+use SimpleSAML\Assert\Assert;
+use SimpleSAML\Auth;
+
+/**
+ * Hook to for use with unit tests
+ *
+ * @param array &$data  Some data
+ */
+function unittest_hook_valid(array &$data)
+{
+    $data['summary'][] = 'success';
+}

tests/modules/unittest/hooks/invalid_hook_prefix.php

+<?php
+
+// Hook detection should not load this file since it does not conform to the hook naming scheme