saml2/idp/SSOService: Log warning if the AssertionConsumerService in the request is invalid.

git-svn-id: https://simplesamlphp.googlecode.com/svn/trunk@1831 44740490-163a-0410-bde0-09ae8108e29a

www/saml2/idp/SSOService.php

@@ -149,8 +149,16 @@ if (isset($_REQUEST['SAMLRequest'])) {
 		$spmetadata = $metadata->getMetaData($spentityid, 'saml20-sp-remote');
 
 		$consumerURL = $authnrequest->getAssertionConsumerServiceURL();
-		$consumerArray = SimpleSAML_Utilities::arrayize($spmetadata['AssertionConsumerService']);
-		if (($consumerURL != NULL) && (array_search($consumerURL, $consumerArray) !== FALSE)) $requestcache['ConsumerURL'] = $consumerURL;
+		if ($consumerURL !== NULL) {
+			$consumerArray = SimpleSAML_Utilities::arrayize($spmetadata['AssertionConsumerService']);
+			if (in_array($consumerURL, $consumerArray, TRUE)) {
+				$requestcache['ConsumerURL'] = $consumerURL;
+			} else {
+				SimpleSAML_Logger::warning('Authentication request from ' . var_export($spentityid, TRUE) .
+					' contains invalid AssertionConsumerService URL. Was ' .
+					var_export($consumerURL, TRUE) . ', could be ' . var_export($consumerArray, TRUE) . '.');
+			}
+		}
 
 		$IDPList = $authnrequest->getIDPList();