Repair broken (but passing) tests and add more coverage
The protectindexpage test was broken and never changed the protectindexpage setting, but the logic was also broken so it always passed and never got past the protected index page guard in the controller so not a lot of code in the controller was run. Also add more tests for the metadata controllers.
Showing
- modules/saml/src/Controller/Metadata.php 12 additions, 5 deletionsmodules/saml/src/Controller/Metadata.php
- modules/saml/src/IdP/SAML2.php 6 additions, 2 deletionsmodules/saml/src/IdP/SAML2.php
- src/SimpleSAML/Auth/ProcessingChain.php 2 additions, 1 deletionsrc/SimpleSAML/Auth/ProcessingChain.php
- tests/modules/saml/src/Controller/MetadataTest.php 193 additions, 16 deletionstests/modules/saml/src/Controller/MetadataTest.php
- tests/modules/saml/src/Controller/ServiceProviderTest.php 78 additions, 16 deletionstests/modules/saml/src/Controller/ServiceProviderTest.php
Loading
Please register or sign in to comment