Fix accidentally removed line

lib/SimpleSAML/Metadata/MetaDataStorageHandler.php

@@ -295,8 +295,8 @@ class MetaDataStorageHandler implements ClearableState
      * This function looks up the metadata for the given entity id in the given set. It will throw an
      * exception if it is unable to locate the metadata.
      *
-     * @param string|null $entityId The entity id we are looking up. This parameter may be NULL, in which case we look up
-     * the current entity id based on the current hostname/path.
+     * @param string|null $entityId The entity id we are looking up. This parameter may be NULL,
+     * in which case we look up the current entity id based on the current hostname/path.
      * @param string $set The set of metadata we are looking up the entity id in.
      *
      * @return array The metadata array describing the specified entity.

lib/SimpleSAML/Metadata/Sources/MDQ.php

@@ -287,7 +287,9 @@ class MDQ extends \SimpleSAML\Metadata\MetaDataStorageSource
 
         $data = self::getParsedSet($entity, $set);
         if ($data === null) {
-            throw new \Exception(__CLASS__ . ': no metadata for set "' . $set . '" available from "' . $entityId . '".');
+            throw new \Exception(
+                __CLASS__ . ': no metadata for set "' . $set . '" available from "' . $entityId . '".'
+            );
         }
 
         try {

modules/core/lib/Auth/Process/PHP.php

@@ -58,6 +58,7 @@ class PHP extends Auth\ProcessingFilter
          * @param array &$attributes
          * @param array &$state
          */
+        $function = function (
             /** @scrutinizer ignore-unused */ array &$attributes,
             /** @scrutinizer ignore-unused */ array &$state
         ) {

modules/saml/lib/Auth/Source/SP.php

@@ -589,7 +589,7 @@ class SP extends \SimpleSAML\Auth\Source
         // Otherwise use extensions that might be defined in the local SP (only makes sense in a proxy scenario)
         if (isset($state['saml:Extensions']) && count($state['saml:Extensions']) > 0) {
             $ar->setExtensions($state['saml:Extensions']);
-        } else if ($this->metadata->getArray('saml:Extensions', null) !== null) {
+        } elseif ($this->metadata->getArray('saml:Extensions', null) !== null) {
             $ar->setExtensions($this->metadata->getArray('saml:Extensions'));
         }
 

tests/lib/SimpleSAML/Store/RedisTest.php

@@ -54,6 +54,7 @@ class RedisTest extends TestCase
         $this->mocked_redis->method('del')
                            ->will($this->returnCallback([$this, 'delMocked']));
 
+        $nop = /** @return void */ function () {
             return;
         };