Do not reuse variable

modules/metarefresh/lib/ARP.php

@@ -33,31 +33,31 @@ class ARP
      * Constructor
      *
      * @param array $metadata
-     * @param string $attributemap
+     * @param string $attributemap_filename
      * @param string $prefix
      * @param string $suffix
 	 */
-    public function __construct($metadata, $attributemap, $prefix, $suffix)
+    public function __construct($metadata, $attributemap_filename, $prefix, $suffix)
     {
         $this->metadata = $metadata;
         $this->prefix = $prefix;
         $this->suffix = $suffix;
 
-        if (isset($attributemap)) {
-            $this->loadAttributeMap($attributemap);
+        if (isset($attributemap_filename)) {
+            $this->loadAttributeMap($attributemap_filename);
         }
     }
 	
     /**
-     * @param string $attributemap
+     * @param string $attributemap_filename
      *
      * @return void
      */
-    private function loadAttributeMap($attributemap)
+    private function loadAttributeMap($attributemap_filename)
     {
         $config = \SimpleSAML\Configuration::getInstance();
-        include($config->getPathValue('attributemap', 'attributemap/') . $attributemap . '.php');
-        // Note that $attributemap was a string before the call to include() and is now an array!
+        include($config->getPathValue('attributemap', 'attributemap/') . $attributemap_filename . '.php');
+        // Note that $attributemap is defined in the included attributemap-file!
         $this->attributes = $attributemap;
     }