Skip to content
Snippets Groups Projects
Commit 8aac150f authored by Tim van Dijen's avatar Tim van Dijen
Browse files

Fix typo + authentication-failure on empty attributes-array

An empty array shouldn't lead to an aborted logon.
Example when we try to get the 'mail' attribute:
UserA has a value set in the mail-attribute and passes the test -> Negotiate logon succeeds
UserB has an empty mail-attribute and fails the test -> Negotiate logon fails and the user has to log on manually (fallback to LDAP is initiated)
parent bcd7240c
Branches
Tags
No related merge requests found
...@@ -116,9 +116,9 @@ class sspmod_negotiate_Auth_Source_Negotiate extends SimpleSAML_Auth_Source ...@@ -116,9 +116,9 @@ class sspmod_negotiate_Auth_Source_Negotiate extends SimpleSAML_Auth_Source
assert('FALSE'); assert('FALSE');
} }
SimpleSAML\Logger::debug('Negotiate - authenticate(): looking for Negotate'); SimpleSAML\Logger::debug('Negotiate - authenticate(): looking for Negotiate');
if (!empty($_SERVER['HTTP_AUTHORIZATION'])) { if (!empty($_SERVER['HTTP_AUTHORIZATION'])) {
SimpleSAML\Logger::debug('Negotiate - authenticate(): Negotate found'); SimpleSAML\Logger::debug('Negotiate - authenticate(): Negotiate found');
$this->ldap = new SimpleSAML_Auth_LDAP( $this->ldap = new SimpleSAML_Auth_LDAP(
$this->hostname, $this->hostname,
$this->enableTLS, $this->enableTLS,
...@@ -151,7 +151,7 @@ class sspmod_negotiate_Auth_Source_Negotiate extends SimpleSAML_Auth_Source ...@@ -151,7 +151,7 @@ class sspmod_negotiate_Auth_Source_Negotiate extends SimpleSAML_Auth_Source
$user = $auth->getAuthenticatedUser(); $user = $auth->getAuthenticatedUser();
SimpleSAML\Logger::info('Negotiate - authenticate(): '.$user.' authenticated.'); SimpleSAML\Logger::info('Negotiate - authenticate(): '.$user.' authenticated.');
$lookup = $this->lookupUserData($user); $lookup = $this->lookupUserData($user);
if ($lookup) { if ($lookup !== null) {
$state['Attributes'] = $lookup; $state['Attributes'] = $lookup;
// Override the backend so logout will know what to look for // Override the backend so logout will know what to look for
$state['LogoutState'] = array( $state['LogoutState'] = array(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment