Make the "check for updates" new feature configurable.

Add a configuration option named 'admin.checkforupdates' to enable or disable this feature.

config-templates/config.php

@@ -76,9 +76,20 @@ $config = array(
      * You can also put a hash here; run "bin/pwgen.php" to generate one.
      */
     'auth.adminpassword' => '123',
+
+    /*
+     * Set this options to true if you want to require administrator password to access the web interface
+     * or the metadata pages, respectively.
+     */
     'admin.protectindexpage' => false,
     'admin.protectmetadata' => false,
 
+    /*
+     * Set this option to false if you don't want SimpleSAMLphp to check for new stable releases when
+     * visiting the configuration tab in the web interface.
+     */
+    'admin.checkforupdates' => true,
+
     /*
      * Array of domains that are allowed when generating links or redirects
      * to URLs. SimpleSAMLphp will use this option to determine whether to

modules/core/www/frontpage_config.php

@@ -70,30 +70,28 @@ $allLinks = array(
 );
 SimpleSAML\Module::callHooks('frontpage', $allLinks);
 
-// get latest version
-$api_url = 'https://api.github.com/repos/simplesamlphp/simplesamlphp/releases';
-$ch = curl_init($api_url.'/latest');
-curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
-curl_setopt($ch, CURLOPT_USERAGENT, 'SimpleSAMLphp');
-curl_setopt($ch, CURLOPT_TIMEOUT, 2);
-$response = curl_exec($ch);
-
-if (curl_getinfo($ch, CURLINFO_HTTP_CODE) === 200) {
-	$latest = json_decode($response, true);
-	$current = $config->getVersion();
-	if ($current !== 'master' && version_compare($current, ltrim($latest['tag_name'], 'v'), 'lt')) {
-		$outdated = true;
-		$warnings[] = array(
-			'{core:frontpage:warnings_outdated}',
-			array('%LATEST_URL%' => $latest['html_url'])
-		);
+// check for updates
+if ($config->getBoolean('admin.checkforupdates', true)) {
+	$api_url = 'https://api.github.com/repos/simplesamlphp/simplesamlphp/releases';
+	$ch = curl_init($api_url.'/latest');
+	curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
+	curl_setopt($ch, CURLOPT_USERAGENT, 'SimpleSAMLphp');
+	curl_setopt($ch, CURLOPT_TIMEOUT, 2);
+	$response = curl_exec($ch);
+
+	if (curl_getinfo($ch, CURLINFO_HTTP_CODE) === 200) {
+		$latest = json_decode($response, true);
+		$current = $config->getVersion();
+		if ($current !== 'master' && version_compare($current, ltrim($latest['tag_name'], 'v'), 'lt')) {
+			$outdated = true;
+			$warnings[] = array(
+				'{core:frontpage:warnings_outdated}',
+				array('%LATEST_URL%' => $latest['html_url'])
+			);
+		}
 	}
+	curl_close($ch);
 }
-curl_close($ch);
-
-
-
-
 
 $enablematrix = array(
 	'saml20-idp' => $config->getBoolean('enable.saml20-idp', false),