Merge pull request #863 from smotornyuk/update-session-params-before-session-start

Make sure that session is closed and only then update cookie params

lib/SimpleSAML/SessionHandlerPHP.php

@@ -343,6 +343,11 @@ class SessionHandlerPHP extends SessionHandler
             );
         }
 
+        if (session_id() !== '') {
+            // session already started, close it
+            session_write_close();
+        }
+
         session_set_cookie_params(
             $cookieParams['lifetime'],
             $cookieParams['path'],
@@ -351,11 +356,6 @@ class SessionHandlerPHP extends SessionHandler
             $cookieParams['httponly']
         );
 
-        if (session_id() !== '') {
-            // session already started, close it
-            session_write_close();
-        }
-
         session_id($sessionID);
         $this->sessionStart();
     }