Fixes for modules/authlinkedin

modules/authlinkedin/lib/Auth/Source/LinkedIn.php

@@ -23,8 +23,13 @@ class LinkedIn extends \SimpleSAML\Auth\Source
      */
     const AUTHID = 'authlinkedin:AuthId';
 
+    /** @var string */
     private $key;
+
+    /** @var string */
     private $secret;
+
+    /** @var string */
     private $attributes;
 
 
@@ -33,6 +38,7 @@ class LinkedIn extends \SimpleSAML\Auth\Source
      *
      * @param array $info  Information about this authentication source.
      * @param array $config  Configuration.
+     * @throws \Exception
      */
     public function __construct($info, $config)
     {
@@ -68,6 +74,7 @@ class LinkedIn extends \SimpleSAML\Auth\Source
      * Documentation at: http://developer.linkedin.com/docs/DOC-1008
      *
      * @param array &$state  Information about the current authentication.
+     * @return void
      */
     public function authenticate(&$state)
     {
@@ -104,6 +111,10 @@ class LinkedIn extends \SimpleSAML\Auth\Source
     }
 
 
+    /**
+     * @param array &$state
+     * @return void
+     */
     public function finalStep(&$state)
     {
         $requestToken = $state['authlinkedin:requestToken'];

modules/authlinkedin/www/linkback.php

@@ -23,6 +23,7 @@ if (array_key_exists('oauth_verifier', $_REQUEST)) {
 assert(array_key_exists(\SimpleSAML\Module\authlinkedin\Auth\Source\LinkedIn::AUTHID, $state));
 $sourceId = $state[\SimpleSAML\Module\authlinkedin\Auth\Source\LinkedIn::AUTHID];
 
+/** @var \SimpleSAML\Module\authlinkedin\Auth\Source\LinkedIn|null $source */
 $source = \SimpleSAML\Auth\Source::getById($sourceId);
 if ($source === null) {
     throw new \Exception('Could not find authentication source with id '.$sourceId);