Merge pull request #592 from mschwager/master

Added tests for SimpleSAMLUtilsSystem

composer.json

@@ -46,7 +46,8 @@
     "require-dev": {
         "ext-pdo_sqlite": "*",
         "phpunit/phpunit": "~4.8",
-        "satooshi/php-coveralls": "^1.0"
+        "satooshi/php-coveralls": "^1.0",
+        "mikey179/vfsStream": "~1.6"
     },
     "suggests": {
         "predis/predis": "1.1.1"

tests/lib/SimpleSAML/Utils/SystemTest.php

+<?php
+
+namespace SimpleSAML\Test\Utils;
+
+use \SimpleSAML_Configuration as Configuration;
+use \SimpleSAML\Utils\System;
+
+use \org\bovigo\vfs\vfsStream;
+
+/**
+ * Tests for SimpleSAML\Utils\System.
+ */
+class SystemTest extends \PHPUnit_Framework_TestCase
+{
+    const ROOTDIRNAME = 'testdir';
+    const DEFAULTTEMPDIR = 'tempdir';
+
+    public function setUp()
+    {
+        $this->root = vfsStream::setup(
+            self::ROOTDIRNAME,
+            null,
+            array(
+                self::DEFAULTTEMPDIR => array(),
+            )
+        );
+        $this->root_directory = vfsStream::url(self::ROOTDIRNAME);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::getOS
+     * @test
+     */
+    public function testGetOSBasic()
+    {
+        $res = System::getOS();
+
+        $this->assertInternalType("int", $res);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::resolvePath
+     * @test
+     */
+    public function testResolvePathRemoveTrailingSlashes()
+    {
+        $base = "/base////";
+        $path = "test";
+
+        $res = System::resolvePath($path, $base);
+        $expected = "/base/test";
+
+        $this->assertEquals($expected, $res);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::resolvePath
+     * @test
+     */
+    public function testResolvePathPreferAbsolutePathToBase()
+    {
+        $base = "/base/";
+        $path = "/test";
+
+        $res = System::resolvePath($path, $base);
+        $expected = "/test";
+
+        $this->assertEquals($expected, $res);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::resolvePath
+     * @test
+     */
+    public function testResolvePathCurDirPath()
+    {
+        $base = "/base/";
+        $path = "/test/.";
+
+        $res = System::resolvePath($path, $base);
+        $expected = "/test";
+
+        $this->assertEquals($expected, $res);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::resolvePath
+     * @test
+     */
+    public function testResolvePathParentPath()
+    {
+        $base = "/base/";
+        $path = "/test/child/..";
+
+        $res = System::resolvePath($path, $base);
+        $expected = "/test";
+
+        $this->assertEquals($expected, $res);
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::writeFile
+     * @test
+     */
+    public function testWriteFileInvalidArguments()
+    {
+        $this->setExpectedException('\InvalidArgumentException');
+        System::writeFile(null, null, null);
+    }
+
+    /**
+     * @requires PHP 5.4.0
+     * @covers \SimpleSAML\Utils\System::writeFile
+     * @test
+     */
+    public function testWriteFileBasic()
+    {
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . self::DEFAULTTEMPDIR;
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        $filename = $this->root_directory . DIRECTORY_SEPARATOR . 'test';
+
+        System::writeFile($filename, '');
+
+        $this->assertFileExists($filename);
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    /**
+     * @requires PHP 5.4.0
+     * @covers \SimpleSAML\Utils\System::writeFile
+     * @test
+     */
+    public function testWriteFileContents()
+    {
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . self::DEFAULTTEMPDIR;
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        $filename = $this->root_directory . DIRECTORY_SEPARATOR . 'test';
+        $contents = 'TEST';
+
+        System::writeFile($filename, $contents);
+
+        $res = file_get_contents($filename);
+        $expected = $contents;
+
+        $this->assertEquals($expected, $res);
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    /**
+     * @requires PHP 5.4.0
+     * @covers \SimpleSAML\Utils\System::writeFile
+     * @test
+     */
+    public function testWriteFileMode()
+    {
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . self::DEFAULTTEMPDIR;
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        $filename = $this->root_directory . DIRECTORY_SEPARATOR . 'test';
+        $mode = 0666;
+
+        System::writeFile($filename, '', $mode);
+
+        $res = $this->root->getChild('test')->getPermissions();
+        $expected = $mode;
+
+        $this->assertEquals($expected, $res);
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::getTempDir
+     * @test
+     */
+    public function testGetTempDirBasic()
+    {
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . self::DEFAULTTEMPDIR;
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        $res = System::getTempDir();
+        $expected = $tempdir;
+
+        $this->assertEquals($expected, $res);
+        $this->assertFileExists($res);
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    /**
+     * @covers \SimpleSAML\Utils\System::getTempDir
+     * @test
+     */
+    public function testGetTempDirNonExistant()
+    {
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . 'nonexistant';
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        $res = System::getTempDir();
+        $expected = $tempdir;
+
+        $this->assertEquals($expected, $res);
+        $this->assertFileExists($res);
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    /**
+     * @requires PHP 5.4.0
+     * @requires OS Linux
+     * @covers \SimpleSAML\Utils\System::getTempDir
+     * @test
+     */
+    public function testGetTempDirBadOwner()
+    {
+        $bad_uid = posix_getuid() + 1;
+
+        $tempdir = $this->root_directory . DIRECTORY_SEPARATOR . self::DEFAULTTEMPDIR;
+        $config = $this->setConfigurationTempDir($tempdir);
+
+        chown($tempdir, $bad_uid);
+
+        $this->setExpectedException('\SimpleSAML_Error_Exception');
+        $res = System::getTempDir();
+
+        $this->clearInstance($config, '\SimpleSAML_Configuration');
+    }
+
+    private function setConfigurationTempDir($directory)
+    {
+        $config = Configuration::loadFromArray(array(
+            'tempdir' => $directory,
+        ), '[ARRAY]', 'simplesaml');
+
+        return $config;
+    }
+
+    protected function clearInstance($service, $className)
+    {
+        $reflectedClass = new \ReflectionClass($className);
+        $reflectedInstance = $reflectedClass->getProperty('instance');
+        $reflectedInstance->setAccessible(true);
+        $reflectedInstance->setValue($service, null);
+        $reflectedInstance->setAccessible(false);
+    }
+}