Skip to content
Snippets Groups Projects
  1. May 28, 2018
  2. May 10, 2018
  3. Apr 13, 2018
  4. Feb 28, 2018
  5. Feb 07, 2018
  6. Jan 21, 2018
  7. Jan 16, 2018
  8. Jan 08, 2018
  9. Jan 06, 2018
  10. Dec 29, 2017
  11. Dec 14, 2017
  12. Dec 05, 2017
  13. Nov 14, 2017
  14. Oct 25, 2017
  15. Oct 19, 2017
  16. Oct 16, 2017
  17. Oct 10, 2017
    • Jaime Pérez Crespo's avatar
      bugfix: Make sure no JS code can be injected into redirected URLs · 5f074e97
      Jaime Pérez Crespo authored
      In order to fix this, we first sanitize any URL given to SimpleSAML\Utils\HTTP::checkURLAllowed() so that we make sure we have a true URL without spurious characters. Secondly, we stop using an "onload" event in the body of the redirect page to trigger the redirect automatically. Instead, we use a "meta refresh" redirection.
      
      This double remediation is because there were two issues here: one, we were printing user input inside a chunk of javascript code. The other exploits the fact that the header() function silently breaks when a null character is part of the URL given to a "Location" header. In that case, the HTTP 302 Redirection doesn't happen, and then the browser loads the HTML and goes through it, running the injected javascript.
      
      This fixes #699.
      Unverified
      5f074e97
  18. Sep 07, 2017
  19. Sep 01, 2017
  20. Jul 20, 2017
    • Scato Eggen's avatar
      Invalidate opcache after writing a file · cd8179d7
      Scato Eggen authored
      When opcache.validate_timestamps is disabled, then the new metadata will not be read after a metarefresh.
      This can be solved by adding the metadata file to an opcache blacklist, but calling opcache_invalidate()
      after writing a file is a nice out-of-the-box solution.
      
      Hopefully, this will enable everybody that is using simplesamlphp to disable opcache.validate_timestamps
      without running into problems.
      cd8179d7
  21. Jul 05, 2017
  22. May 05, 2017
    • Matt Schwager's avatar
      Added tests for SimpleSAML\Utils\Crypto · 8e39cd49
      Matt Schwager authored
      This also required adding an additional argument to
      SimpleSAML\Utils\Crypto::loadPrivateKey to ease in testing. Without
      this additional argument, SimpleSAML_Configuration::getBaseDir eventually
      gets called to determine the private key location.  This doesn't work
      well with vfsstream. This argument shouldn't cause too much trouble, and
      seems cohesive enough with the function's purpose.
      8e39cd49
    • Jaime Pérez Crespo's avatar
      bugfix: SimpleSAML\Utils\Crypto returns true for different strings using PHP < 5.6. · 4bc62965
      Jaime Pérez Crespo authored
      The reason was the lack of conversion to integer for each character of the strings before applying the XOR operator to them. The operator returns always an empty string when applied to two characters, and applying a binary-wise OR between 0 and an empty string, yields 0. Therefore, $diff is always 0, and the function returns true for every two strings with same length, regardless of their contents.
      4bc62965
  23. Apr 26, 2017
Loading