Skip to content
Snippets Groups Projects
  1. Nov 22, 2017
  2. Oct 25, 2017
  3. Oct 19, 2017
  4. Jul 04, 2017
    • Jaime Pérez Crespo's avatar
      Further optimize the SimpleSAML\Module class. · 7b3a5c0d
      Jaime Pérez Crespo authored
      Instead of one cache, we need to use two: one for the list of modules available, and the other for the details for them. Those caches should be filled independently, so that someone calling getModules() does not trigger the code checking of the modules are enabled or finding their hooks.
      7b3a5c0d
  5. Jun 30, 2017
    • Jaime Pérez Crespo's avatar
      Enhance the performance of SimpleSAML\Module. · 4e68df80
      Jaime Pérez Crespo authored
      The issue here is that every time we need to list the modules or check if they are enabled, we just iterate over the modules directory and subdirectories, which is terribly expensive. Instead of doing so, we build a cache of modules specifying if they are enabled or not. In the end, this is also fixing another issue, given that enabling/disabling a module in the middle of a request being processed could lead to inconsistencies and unexpected behaviour (likely exceptions and horrible crashes). Modules should be checked in the beginning of a request and their state (enabled/disabled) frozen until the request is processed to avoid that, and this is the way to achieve so.
      
      Additionally, we take the chance to check if modules are enabled when we search for them. This reduces the processing time to around a third of the original without this fix.
      4e68df80
  6. Mar 09, 2016
  7. Feb 22, 2016
  8. Feb 19, 2016
  9. Aug 05, 2015
  10. May 26, 2015
    • Olav Morken's avatar
      Ensure that config.php is optional for module loading. · 0fc3f8a7
      Olav Morken authored
      Currently, if we try to load a class from a module, and the config.php
      is absent, we will get an error about the missing configuration file.
      
      There is no reason for the configuration file to be mandatory here,
      since we have reasonable fallbacks, so fix the code to make it
      optional.
      
      This should make it easier to write tests for code in modules.
      0fc3f8a7
  11. Apr 21, 2015
  12. Jan 15, 2015
  13. Jul 09, 2014
  14. Jan 09, 2013
  15. Apr 12, 2012
  16. Nov 26, 2010
  17. Jul 09, 2010
  18. Dec 16, 2009
  19. Sep 01, 2008
  20. Aug 20, 2008
  21. Aug 18, 2008
Loading