Skip to content
Snippets Groups Projects
  1. Oct 01, 2019
  2. Sep 24, 2019
  3. Sep 16, 2019
  4. Aug 31, 2019
  5. Jul 24, 2019
  6. Jun 06, 2019
  7. Feb 03, 2019
  8. Nov 21, 2018
  9. Oct 17, 2018
  10. Aug 05, 2018
  11. May 31, 2018
  12. May 23, 2018
  13. Apr 18, 2018
  14. Feb 22, 2018
  15. Nov 29, 2017
  16. Oct 19, 2017
  17. Jun 06, 2017
    • Jaime Pérez Crespo's avatar
      Fix a bug in the PHP session handler · ab344d88
      Jaime Pérez Crespo authored
      When unserializing the session fails, the handler should return null instead of false. Additionally, SimpleSAML_Session::load() should make sure that it got an instance of SimpleSAML_Session, to avoid any misbehaving handlers to generate an issue.
      
      This resolves #616.
      ab344d88
  18. Apr 01, 2017
  19. Sep 27, 2016
  20. Jul 04, 2016
  21. Jul 03, 2016
  22. Jul 02, 2016
    • Jaime Pérez's avatar
      bugfix: Stop SimpleSAML_SessionHandler::newSessionId() from initializing the session. · 4056af12
      Jaime Pérez authored
      Historically, SimpleSAML_SessionHandler::newSessionId() has also created the session, sending the cookies to the browser. This is problematic both because given the name of the method one would not assume such behaviour, and also because even for transient sessions the handler would then try to set cookies. When we are using a transient session, it is likely to be because we cannot set cookies or because there was a temporary error when loading the session. If we try to set the cookies even for transient sessions, we could either get an error because cookies cannot be set, or overwrite the previous session cookies with transient ones, trashing a legitimate session in case a temporary error occurs.
      
      As a side effect, this can also cause behaviours like the one described in issue #413. There's no point in trying to set the cookies when it's not possible, so we shouldn't even try, and save us the errors.
      
      To fix this, we made SimpleSAML_SessionHandler::setCookie() abstract, forcing each extending class to implement it. The former implementation is moved to SimpleSAML_SessionHandlerCookie, and the SimpleSAML_SessionHandlerPHP gets a new method that starts the session, effectively sending the cookie. SimpleSAML_Session would then be responsible to call the setCookie() method of the session handler when creating a regular session, and skip it when creating a transient one. This introduces a bug, since SimpleSAML_Session was trying to set the auth token cookie calling the same setCookie() method in the session handler. We fixed that by using SimpleSAML\Utils\HTTP::setCookie() instead, in 8756835b.
      
      This resolves #413.
      4056af12
    • Jaime Pérez's avatar
    • Jaime Pérez's avatar
      Fix indentation. · 271be82c
      Jaime Pérez authored
      271be82c
  23. Jun 08, 2016
  24. Apr 12, 2016
  25. Apr 07, 2016
  26. Feb 15, 2016
  27. Oct 26, 2015
  28. Aug 04, 2015
Loading