Skip to content
Snippets Groups Projects
  1. May 29, 2022
  2. Mar 16, 2022
  3. Feb 06, 2022
    • Thijs Kinkhorst's avatar
      Change logging date formatting string from strftime() to date(). · dfbb7e65
      Thijs Kinkhorst authored
      strftime is deprecated and will be removed in PHP 9. SSP 2.0 is our
      chance to change this format as it's exposed to installers of SSP.
      
      The approch is to keep it simple and just change the format to PHP's
      built in date() function which remains supported. Also we do not try
      to localize the logging date/timestamps anymore. This matches the syslog
      approach that this format tried to mimic. We are using the day without
      leading zeroes now also to be a bit closer to how syslog does it.
      dfbb7e65
  4. Aug 27, 2021
  5. Mar 12, 2021
  6. Jan 22, 2021
  7. Sep 15, 2020
  8. Sep 10, 2020
  9. Jun 13, 2020
  10. Apr 30, 2020
  11. Feb 15, 2020
  12. Feb 14, 2020
  13. Dec 24, 2019
  14. Oct 01, 2019
  15. Sep 24, 2019
  16. Sep 16, 2019
    • Jaime Pérez Crespo's avatar
      Remove superfluous log message · 512b9cf3
      Jaime Pérez Crespo authored
      If we reach this point, we're likely already logging the error somewhere else (i.e. the session handler in use), so there's no point on logging the exception's message again.
      512b9cf3
  17. Aug 31, 2019
  18. Aug 29, 2019
    • Jaime Pérez Crespo's avatar
      Make sure we respect log message order · 014992c8
      Jaime Pérez Crespo authored
      When we are logging something and the logger hasn't been initialized, the messages are deferred and flushed by a shutdown handler. However, when we initialize a session, we set the track ID in the logger, effectively initializing it with everything we need. When we log something and then load the session (or create it), any subsequent logs will be dumped, but the deferred logs will wait until shutdown, changing the order in which they were emitted.
      
      This patch makes sure we flush the deferred logs as soon as we have a track ID (can either be set manually or by, most typically, loading a session). That way, we get those logs out as soon as we can, and subsequent logs entries will be dumped afterwards, keeping their relative order.
      
      This closes #1107
      Unverified
      014992c8
  19. Aug 28, 2019
  20. Jun 06, 2019
  21. Feb 03, 2019
  22. Jan 10, 2019
  23. Oct 17, 2018
  24. May 31, 2018
  25. May 22, 2018
  26. Apr 13, 2018
  27. Dec 08, 2017
  28. Oct 25, 2017
  29. Oct 19, 2017
  30. Nov 03, 2016
  31. Jul 04, 2016
    • Jaime Pérez's avatar
      bugfix: Make sure SimpleSAML_Session::getSessionFromRequest() always raises an... · 52c6bf04
      Jaime Pérez authored
      bugfix: Make sure SimpleSAML_Session::getSessionFromRequest() always raises an exception when a transient session is used due to a misconfiguration or a temporary failure fetching an existing session.
      
      Transient sessions are just an exceptional event, and they shouldn't be treated as regular sessions. Therefore, if we are trying to get the current session and end up with a transient one, that's because an error occurred and we should raise an exception. Since exceptions due to secure cookies trying to be set via an insecure channel are likely to be misconfigurations, we treat them like that, raising a SimpleSAML\Error\CriticalConfigurationError.
      
      Additionally, we capture exceptions in the SimpleSAML\Logger::flush() method, ensuring the error reported in #413 doesn't happen again.
      
      This resolves #356.
      52c6bf04
Loading