Skip to content
Snippets Groups Projects
  1. Sep 25, 2019
  2. Sep 24, 2019
  3. Sep 19, 2019
  4. Sep 18, 2019
  5. Sep 16, 2019
    • Tim van Dijen's avatar
      Add deprecation note · 5f264d4d
      Tim van Dijen authored
      5f264d4d
    • Menco Bolt's avatar
      Add authData (#1106) · a4377301
      Menco Bolt authored
      a4377301
    • Jaime Pérez Crespo's avatar
      Make the initially visible block in the expander optional · b260aebe
      Jaime Pérez Crespo authored
      If there is no "general" block defined in the expander, it just won't show.
      b260aebe
    • Jaime Pérez Crespo's avatar
      Do not attempt to set the session ID for transient sessions · 8b4b2138
      Jaime Pérez Crespo authored
      It just doesn't make any sense. If we managed to get it from an existing cookie, it serves no purpose, as at this point we couldn't load the session anyway, and what we use to track users is the track ID, not the session ID. Additionally, since this is a transient session, we're not going to push the cookie to the browser (we might not even can do that), so it's really pointless to set the session ID.
      
      This, additionally, was causing that the Session class would be unable to initialize and register a transient session if the issue that forced us to use a transient in the first place was an issue with the session handler (e.g. missing PHP extensions or dependencies, or connection failure to the backend, etc). Under such circumstances, the code removed here will not work either, since the session handler will continue to fail to initialize. This would cause the exception handler to jump in, completely losing control of the execution, and making it impossible to display the error to the user (since the transient session creation is never completed, it cannot be used later where it is needed in the SimpleSAML\Error\Error class).
      
      This resolves #914.
      8b4b2138
    • Jaime Pérez Crespo's avatar
      Make it explicit that fetching or creating a session handler could throw an exception · e968169e
      Jaime Pérez Crespo authored
      This could happen when the handler is depending on a PHP extension, or connection to a database fails, or any other circumstance that may trigger an exception in the constructor of the session handler itself. We should be aware of this when using the session handler, therefore we update the phpdoc here to reflect that.
      e968169e
    • Jaime Pérez Crespo's avatar
      Fix broken web server aliases / rewritten URLs · 29b63583
      Jaime Pérez Crespo authored
      This resolves #1023, resolves #1093 and closes #1095.
      29b63583
    • Jaime Pérez Crespo's avatar
      Fix header warnings from log flushing · b278b2b4
      Jaime Pérez Crespo authored
      This resolves #1176
      b278b2b4
    • Jaime Pérez Crespo's avatar
      Specify button as a submit button · 3fa2c2d7
      Jaime Pérez Crespo authored
      Apparently, IE does not mark buttons as submit buttons when type is missing by default, making it impossible to submit a form.
      
      This resolves #908.
      3fa2c2d7
    • Jaime Pérez Crespo's avatar
      Remove misleading phpdoc · 2748d2da
      Jaime Pérez Crespo authored
      This comment used to be true, but the behaviour was changed in 3c52b289 in order to purge old data more often.
      2748d2da
    • Jaime Pérez Crespo's avatar
      Downgrade missing translations from error to debug · d7f52cdd
      Jaime Pérez Crespo authored
      This is something the developer of a module is supposed to deal with. If you are just using SSP, it doesn't make much sense to have your log files flooded by errors about missing translation files or directories, since you cannot do anything about it and the original english text will be used anyway.
      d7f52cdd
    • Jaime Pérez Crespo's avatar
      Remove superfluous log message · 512b9cf3
      Jaime Pérez Crespo authored
      If we reach this point, we're likely already logging the error somewhere else (i.e. the session handler in use), so there's no point on logging the exception's message again.
      512b9cf3
  6. Sep 13, 2019
  7. Sep 12, 2019
  8. Sep 11, 2019
Loading