Removed unused variables (#960)

tests/lib/SimpleSAML/DatabaseTest.php

@@ -92,7 +92,7 @@ class DatabaseTest extends TestCase
         );
 
         $this->config = new \SimpleSAML\Configuration($config, "test/SimpleSAML/DatabaseTest.php");
-        $db = SimpleSAML\Database::getInstance($this->config);
+        SimpleSAML\Database::getInstance($this->config);
     }
 
 

tests/lib/SimpleSAML/Utils/CryptoTest.php

@@ -243,7 +243,6 @@ PHP;
      */
     public function testBadHashAlgorithmValid()
     {
-        $pw = "password";
         $algorithm = "wtf";
         $hash = "{".$algorithm."}B64STRING";
 

tests/lib/SimpleSAML/Utils/SystemTest.php

@@ -226,7 +226,7 @@ class SystemTest extends TestCase
         chown($tempdir, $bad_uid);
 
         $this->setExpectedException('\SimpleSAML\Error\Exception');
-        $res = System::getTempDir();
+        System::getTempDir();
 
         $this->clearInstance($config, '\SimpleSAML\Configuration');
     }

tests/lib/SimpleSAML/Utils/XMLTest.php

@@ -150,7 +150,7 @@ class XMLTest extends TestCase
     {
         $dom = new \DOMDocument();
         $element = $dom->appendChild(new \DOMElement('root'));
-        $comment = $element->appendChild(new \DOMComment(''));
+        $element->appendChild(new \DOMComment(''));
 
         XML::getDOMText($element);
     }

tests/modules/core/lib/Auth/Process/AttributeAddTest.php

@@ -153,7 +153,7 @@ class Test_Core_Auth_Process_AttributeAdd extends TestCase
                 'test' => array('value1'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -172,6 +172,6 @@ class Test_Core_Auth_Process_AttributeAdd extends TestCase
                 'test' => array('value1'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 }

tests/modules/core/lib/Auth/Process/AttributeAlterTest.php

@@ -225,7 +225,7 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -243,7 +243,7 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -258,18 +258,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
             'pattern' => '/wrong/',
         );
 
-        $request = array(
-            'Attributes' => array(
-                 'test' => array('somethingiswrong'),
-             ),
-        );
-
         $request = array(
             'Attributes' => array(
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -286,18 +280,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
             '%remove',
         );
 
-        $request = array(
-            'Attributes' => array(
-                 'test' => array('somethingiswrong'),
-             ),
-        );
-
         $request = array(
             'Attributes' => array(
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -314,18 +302,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
             '%remove',
         );
 
-        $request = array(
-            'Attributes' => array(
-                 'test' => array('somethingiswrong'),
-             ),
-        );
-
         $request = array(
             'Attributes' => array(
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
 
@@ -342,17 +324,11 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase
             'replacement' => null,
         );
 
-        $request = array(
-            'Attributes' => array(
-                 'test' => array('somethingiswrong'),
-             ),
-        );
-
         $request = array(
             'Attributes' => array(
                 'eduPersonAffiliation' => array('emperess', 'emperor'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 }

tests/modules/core/lib/Auth/Process/AttributeCopyTest.php

@@ -139,7 +139,7 @@ class Test_Core_Auth_Process_AttributeCopy extends TestCase
                 'test' => array('value1'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -157,6 +157,6 @@ class Test_Core_Auth_Process_AttributeCopy extends TestCase
                 'test' => array('value1'),
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 }

tests/modules/core/lib/Auth/Process/AttributeLimitTest.php

@@ -208,7 +208,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase
             'invalidArg' => TRUE,
         );
 
-        $result = self::processFilter($config, self::$request);
+        self::processFilter($config, self::$request);
     }
 
     /**
@@ -222,7 +222,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase
 		null
         );
 
-        $result = self::processFilter($config, self::$request);
+        self::processFilter($config, self::$request);
     }
 
 
@@ -464,7 +464,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase
         );
 
 
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**

tests/modules/core/lib/Auth/Process/AttributeRealmTest.php

@@ -51,7 +51,7 @@ class Test_Core_Auth_Process_AttributeRealm extends TestCase
         $request = array(
             'Attributes' => array(),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**

tests/modules/core/lib/Auth/Process/TargetedIDTest.php

@@ -173,7 +173,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase
         $request = array(
             'Attributes' => array(),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -191,7 +191,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase
                 'displayName' => 'Jack Student',
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -209,7 +209,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase
                 'displayName' => 'Jack Student',
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 
     /**
@@ -227,6 +227,6 @@ class Test_Core_Auth_Process_TargetedID extends TestCase
                 'displayName' => 'Jack Student',
             ),
         );
-        $result = self::processFilter($config, $request);
+        self::processFilter($config, $request);
     }
 }