Skip to content
Snippets Groups Projects
Commit 1c1679e1 authored by Jaime Perez Crespo's avatar Jaime Perez Crespo
Browse files

Fix the phpdoc for SimpleSAML\Utils\Random::generateID() and add a constant...

Fix the phpdoc for SimpleSAML\Utils\Random::generateID() and add a constant with the length of generated IDs.
parent c8927b5c
No related branches found
No related tags found
No related merge requests found
...@@ -10,9 +10,14 @@ class Random ...@@ -10,9 +10,14 @@ class Random
{ {
/** /**
* Generate a random identifier, 22 bytes long. * The fixed length of random identifiers.
*/
const ID_LENGTH = 43;
/**
* Generate a random identifier, ID_LENGTH bytes long.
* *
* @return string A 22-bytes long string with a random, hex string. * @return string A ID_LENGTH-bytes long string with a random, hex-encoded string.
* *
* @author Andreas Solberg, UNINETT AS <andreas.solberg@uninett.no> * @author Andreas Solberg, UNINETT AS <andreas.solberg@uninett.no>
* @author Olav Morken, UNINETT AS <olav.morken@uninett.no> * @author Olav Morken, UNINETT AS <olav.morken@uninett.no>
...@@ -20,6 +25,6 @@ class Random ...@@ -20,6 +25,6 @@ class Random
*/ */
public static function generateID() public static function generateID()
{ {
return '_'.bin2hex(openssl_random_pseudo_bytes(21)); return '_'.bin2hex(openssl_random_pseudo_bytes((self::ID_LENGTH - 1)/2));
} }
} }
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment