Fixes for modules/authtwitter

modules/authtwitter/lib/Auth/Source/Twitter.php

@@ -72,6 +72,7 @@ class Twitter extends \SimpleSAML\Auth\Source
      * Log-in using Twitter platform
      *
      * @param array &$state  Information about the current authentication.
+     * @return void
      */
     public function authenticate(&$state)
     {
@@ -103,6 +104,11 @@ class Twitter extends \SimpleSAML\Auth\Source
         $consumer->getAuthorizeRequest($url, $requestToken);
     }
 
+
+    /**
+     * @param array &$state
+     * @return void
+     */
     public function finalStep(&$state)
     {
         $requestToken = $state['authtwitter:authdata:requestToken'];

modules/authtwitter/www/linkback.php

@@ -20,6 +20,7 @@ if (!array_key_exists(\SimpleSAML\Module\authtwitter\Auth\Source\Twitter::AUTHID
 }
 $sourceId = $state[\SimpleSAML\Module\authtwitter\Auth\Source\Twitter::AUTHID];
 
+/** @var \SimpleSAML\Module\authtwitter\Auth\Source\Twitter|null $source */
 $source = \SimpleSAML\Auth\Source::getById($sourceId);
 if ($source === null) {
     throw new \SimpleSAML\Error\BadRequest(