The protectindexpage test was broken and never changed the
protectindexpage setting, but the logic was also broken so
it always passed and never got past the protected index
page guard in the controller so not a lot of code in the
controller was run.

Also add more tests for the metadata controllers.

The protectindexpage test was broken and never changed the
protectindexpage setting, but the logic was also broken so
it always passed and never got past the protected index
page guard in the controller so not a lot of code in the
controller was run.

Also add more tests for the metadata controllers.

We only have the means to generate a transient NameID. If a different
one was requested, the code would crash because nameIdValue would
be unset. Fix that we fall back to transient in such a case.

No functional changes

This reverts commit cd4cb9d4.