Skip to content
Snippets Groups Projects
  1. Jan 12, 2024
  2. Dec 29, 2022
  3. May 29, 2022
  4. Mar 16, 2022
  5. Feb 22, 2022
  6. Aug 30, 2021
  7. Jan 22, 2021
  8. Dec 15, 2020
  9. Nov 05, 2020
  10. Sep 15, 2020
  11. Sep 10, 2020
  12. May 11, 2020
  13. Feb 15, 2020
  14. Dec 24, 2019
  15. Sep 16, 2019
  16. Aug 31, 2019
  17. Jul 24, 2019
  18. Feb 03, 2019
  19. Oct 17, 2018
  20. Aug 18, 2018
  21. May 31, 2018
  22. Jan 21, 2018
  23. Jun 09, 2017
  24. Apr 01, 2017
  25. Dec 05, 2016
  26. Jul 02, 2016
    • Jaime Pérez's avatar
      bugfix: Stop SimpleSAML_SessionHandler::newSessionId() from initializing the session. · 4056af12
      Jaime Pérez authored
      Historically, SimpleSAML_SessionHandler::newSessionId() has also created the session, sending the cookies to the browser. This is problematic both because given the name of the method one would not assume such behaviour, and also because even for transient sessions the handler would then try to set cookies. When we are using a transient session, it is likely to be because we cannot set cookies or because there was a temporary error when loading the session. If we try to set the cookies even for transient sessions, we could either get an error because cookies cannot be set, or overwrite the previous session cookies with transient ones, trashing a legitimate session in case a temporary error occurs.
      
      As a side effect, this can also cause behaviours like the one described in issue #413. There's no point in trying to set the cookies when it's not possible, so we shouldn't even try, and save us the errors.
      
      To fix this, we made SimpleSAML_SessionHandler::setCookie() abstract, forcing each extending class to implement it. The former implementation is moved to SimpleSAML_SessionHandlerCookie, and the SimpleSAML_SessionHandlerPHP gets a new method that starts the session, effectively sending the cookie. SimpleSAML_Session would then be responsible to call the setCookie() method of the session handler when creating a regular session, and skip it when creating a transient one. This introduces a bug, since SimpleSAML_Session was trying to set the auth token cookie calling the same setCookie() method in the session handler. We fixed that by using SimpleSAML\Utils\HTTP::setCookie() instead, in 8756835b.
      
      This resolves #413.
      4056af12
  27. Apr 07, 2016
    • Jaime Perez Crespo's avatar
      Add a method to SimpleSAMLphp_SessionHandlerPHP to restore a session existing... · 8dc545b8
      Jaime Perez Crespo authored
      Add a method to SimpleSAMLphp_SessionHandlerPHP to restore a session existing previously to our own session. This can be used in SimpleSAML_Session to restore the PHP session status previous to calling our API, while also guaranteeing that our session is correctly saved. The documentation has been updated to reflect this and recommend how to deal with conflicting PHP sessions. This closes #244 and resolves #349.
      8dc545b8
  28. Oct 26, 2015
  29. Aug 05, 2015
  30. Aug 04, 2015
  31. Aug 03, 2015
  32. Apr 21, 2015
  33. Jul 09, 2014
Loading