Skip to content
Snippets Groups Projects
  1. Feb 15, 2020
  2. Dec 24, 2019
  3. Sep 16, 2019
  4. Aug 31, 2019
  5. Jul 24, 2019
  6. Feb 03, 2019
  7. Oct 17, 2018
  8. Aug 18, 2018
  9. May 31, 2018
  10. Jan 21, 2018
  11. Jun 09, 2017
  12. Apr 01, 2017
  13. Dec 05, 2016
  14. Jul 02, 2016
    • Jaime Pérez's avatar
      bugfix: Stop SimpleSAML_SessionHandler::newSessionId() from initializing the session. · 4056af12
      Jaime Pérez authored
      Historically, SimpleSAML_SessionHandler::newSessionId() has also created the session, sending the cookies to the browser. This is problematic both because given the name of the method one would not assume such behaviour, and also because even for transient sessions the handler would then try to set cookies. When we are using a transient session, it is likely to be because we cannot set cookies or because there was a temporary error when loading the session. If we try to set the cookies even for transient sessions, we could either get an error because cookies cannot be set, or overwrite the previous session cookies with transient ones, trashing a legitimate session in case a temporary error occurs.
      
      As a side effect, this can also cause behaviours like the one described in issue #413. There's no point in trying to set the cookies when it's not possible, so we shouldn't even try, and save us the errors.
      
      To fix this, we made SimpleSAML_SessionHandler::setCookie() abstract, forcing each extending class to implement it. The former implementation is moved to SimpleSAML_SessionHandlerCookie, and the SimpleSAML_SessionHandlerPHP gets a new method that starts the session, effectively sending the cookie. SimpleSAML_Session would then be responsible to call the setCookie() method of the session handler when creating a regular session, and skip it when creating a transient one. This introduces a bug, since SimpleSAML_Session was trying to set the auth token cookie calling the same setCookie() method in the session handler. We fixed that by using SimpleSAML\Utils\HTTP::setCookie() instead, in 8756835b.
      
      This resolves #413.
      4056af12
  15. Apr 07, 2016
    • Jaime Perez Crespo's avatar
      Add a method to SimpleSAMLphp_SessionHandlerPHP to restore a session existing... · 8dc545b8
      Jaime Perez Crespo authored
      Add a method to SimpleSAMLphp_SessionHandlerPHP to restore a session existing previously to our own session. This can be used in SimpleSAML_Session to restore the PHP session status previous to calling our API, while also guaranteeing that our session is correctly saved. The documentation has been updated to reflect this and recommend how to deal with conflicting PHP sessions. This closes #244 and resolves #349.
      8dc545b8
  16. Oct 26, 2015
  17. Aug 05, 2015
  18. Aug 04, 2015
  19. Aug 03, 2015
  20. Apr 21, 2015
  21. Jul 09, 2014
  22. Sep 13, 2013
  23. Sep 05, 2013
  24. Sep 04, 2013
  25. Mar 29, 2012
  26. Jul 28, 2011
  27. Aug 09, 2010
  28. Jul 13, 2010
  29. Jul 07, 2010
  30. Dec 02, 2009
  31. Aug 17, 2009
  32. Jun 06, 2008
  33. Mar 06, 2008
  34. Mar 05, 2008
Loading