Skip to content
Snippets Groups Projects
Commit efbb3355 authored by Olav Morken's avatar Olav Morken
Browse files

SAML2: Properly initialize DOM elements.

Failure to add the elements to the DOMDocument will result in
canonicalization silently failing.

git-svn-id: https://simplesamlphp.googlecode.com/svn/trunk@2865 44740490-163a-0410-bde0-09ae8108e29a
parent 58c493ae
No related branches found
No related tags found
No related merge requests found
...@@ -110,6 +110,7 @@ class SAML2_XML_md_EntitiesDescriptor extends SAML2_SignedElementHelper { ...@@ -110,6 +110,7 @@ class SAML2_XML_md_EntitiesDescriptor extends SAML2_SignedElementHelper {
if ($parent === NULL) { if ($parent === NULL) {
$doc = new DOMDocument(); $doc = new DOMDocument();
$e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor'); $e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor');
$doc->appendChild($e);
} else { } else {
$e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor'); $e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor');
$parent->appendChild($e); $parent->appendChild($e);
......
...@@ -202,6 +202,7 @@ class SAML2_XML_md_EntityDescriptor extends SAML2_SignedElementHelper { ...@@ -202,6 +202,7 @@ class SAML2_XML_md_EntityDescriptor extends SAML2_SignedElementHelper {
if ($parent === NULL) { if ($parent === NULL) {
$doc = new DOMDocument(); $doc = new DOMDocument();
$e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor'); $e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor');
$doc->appendChild($e);
} else { } else {
$e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor'); $e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor');
$parent->appendChild($e); $parent->appendChild($e);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment