Skip to content
Snippets Groups Projects
  1. Sep 06, 2016
  2. Sep 05, 2016
  3. Aug 31, 2016
  4. Aug 30, 2016
  5. Aug 25, 2016
  6. Aug 23, 2016
  7. Aug 22, 2016
  8. Aug 17, 2016
  9. Aug 16, 2016
  10. Aug 15, 2016
    • Jaime Pérez's avatar
      Multiple enhancements and fixes to IDPList support in proxy mode. · c70e0b75
      Jaime Pérez authored
      - Bugfix: the modules/saml/www/proxy/invalid_session.php shouldn't call directly the error handler in sspmod_saml_IdP_SAML2. Instead, it should use the SimpleSAML_Auth_State::throwException() method to let it handle the exception appropriately (in this case, it should always return back to the requester).
      - The standard specifies that a "urn:oasis:names:tc:SAML:2.0:status:NoSupportedIDP" or "urn:oasis:names:tc:SAML:2.0:status:NoAvailableIDP" second-level status code should be returned to the requester in case an error occurs. Add a couple of exceptions to represent both statuses, and use them to set the right status code in the response.
      - We shouldn't ask the user to logout in case the IDPList does not offer an IdP we recognize, or in case the proxy enforces the use of an IdP ('idp' configuration option in the auth source) and such IdP is in the IDPList.
      - Similarly, these two cases should also handled in case we are authenticating for the first time, not only when reauthenticating.
      c70e0b75
    • Jaime Pérez's avatar
      bugfix: Fix a bug in AuthMemCookie that prevented the cookie from being set. · 0bd93f6f
      Jaime Pérez authored
      This was due to incorrect use of the SimpleSAML_SessionHandler::setCookie() method to set the cookie, instead of SimpleSAML\Utils\HTTP::setCookie().
      0bd93f6f
  11. Aug 10, 2016
    • Jaime Pérez's avatar
      Make the 'debug' configuration option more fine-grained. · 6c3d49f9
      Jaime Pérez authored
      Some things, like logging of SAML messages or backtraces, are controlled with the 'debug' configuration option. However, it might be possible that we don't want one while we want the other, but that's impossible with just one option.
      
      This commit allows us to configure debugging options independently, but groupping all of them together. This is particularly useful if we want to log backtraces to debug errors, for example, but we don't want to log SAML messages to keep the privacy of the users. This also allows us to get rid of the 'debug.validatexml' configuration option, and group it with other debug options.
      
      This changes are backwards-compatible. Old and new configurations will work at the same time.
      6c3d49f9
    • Jaime Pérez's avatar
      Log backtraces with the same log level as the error messages, whatever that is. · 0858c10c
      Jaime Pérez authored
      It's not very useful to log backtraces always as debug, since that implies getting all the log messages, while backtraces would still help debug a particular error.
      0858c10c
    • Jaime Pérez's avatar
      Typos. · c08ee897
      Jaime Pérez authored
      c08ee897
    • Jaime Pérez's avatar
      bugfix: Avoid the SAML2 IdP resilient to failures when getting DOMNodeList attribute values. · bd5ede94
      Jaime Pérez authored
      Due to recent changes in the SAML2 library, when an attribute has a value that contains XML, its contents are returned as a DOMNodeList instead of a string. This causes problems when running as a proxy, since the SAML2 IdP will obtain attributes in a format that cannot be cast to string. Regardless of the attribute encoding configured in the IdP for a remote SP, we should handle those cases gracefully, so that the IdP don't end up in an uncaught exception.
      bd5ede94
  12. Aug 08, 2016
    • Jaime Pérez's avatar
      bugfix: Make sure we log the user out before reauthenticating. · 0a6f9cfd
      Jaime Pérez authored
      When acting as a proxy, SimpleSAMLphp was re-authenticating the user in case the IdP that authenticated a user in a valid session was not included in the list of IdPs provided by an SP asking for authentication. Since we cannot use Single Sign On there, we should ask the user to logout before authenticating again, avoiding an inconsistent session with SPs associated to different IdPs.
      
      This resolves #84.
      0a6f9cfd
    • Jaime Pérez's avatar
      Minor fixes in the SAML SP test class. · 01c75e44
      Jaime Pérez authored
      Basically, phpdoc formatting and fixing some classes not using namespaces.
      01c75e44
  13. Aug 06, 2016
  14. Aug 05, 2016
Loading